Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding account and skipping folder configuration crash. #7436

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Oct 30, 2024

  • when adding account on mac OS and skipping the folder configuration step, it would crash and it would add an empty user as an account.
  • the dialog for configuring folder it was never going away once the user would click on skip.

@camilasan camilasan force-pushed the bugfix/accounts2 branch 2 times, most recently from 24235b5 to afc2afc Compare November 4, 2024 20:13
@camilasan camilasan changed the title WIP: Bugfix/accounts2 Fix adding account and skipping folder configuration crash. Nov 5, 2024
@camilasan camilasan marked this pull request as ready for review November 5, 2024 09:41
@camilasan
Copy link
Member Author

/backport to stable-3.14

- Use qAsConst.

Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7436-d9ed7cca2d2bd8ba4318752abf1307f64f1a6ea5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.0% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)
53 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants